Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show informative error message when a merge conflict is detected in a YAML file. #100

Conversation

luisdelarosa
Copy link
Contributor

This fixes issue #69.
All in one nice, squashed commit.
😃

@fabiopelosin
Copy link
Member

💥 😄 🍻 Nice! Perfect and clean.... Thanks for the contribution!

fabiopelosin added a commit that referenced this pull request Apr 7, 2014
…yaml_squashed

Show informative error message when a merge conflict is detected in a YAML file.
@fabiopelosin fabiopelosin merged commit 0f24d8f into CocoaPods:master Apr 7, 2014
@alloy
Copy link
Member

alloy commented Apr 8, 2014

Very nice! I think the error message could use some improvement, though. E.g. “Merge conflict(s) detected” -> “Merge conflict detected in spec repo. Please change to the Git repo at ~/.cocoapods/repos/NAME and solve the conflict manually.”

@fabiopelosin
Copy link
Member

This error is not specify to the specs repo. For example it could be the result of a merge conflict in the Podfile.lock file.

@alloy
Copy link
Member

alloy commented Apr 8, 2014

Ok, then it needs to be rephrased, but the point is that the error message should be informative about what the use should do.

@segiddins
Copy link
Member

Maybe we should add a method that takes a path so the user can be told which specific YAML file has the conflict?

@fabiopelosin
Copy link
Member

@segiddins or another method to helper which reads the file directly?

@segiddins
Copy link
Member

Yeah. That way it can point out which files load failed.

-Samuel E. Giddins

On Apr 18, 2014, at 1:33 AM, Fabio Pelosin notifications@github.com wrote:

@segiddins or another method to helper which reads the file directly.


Reply to this email directly or view it on GitHub.

@alloy
Copy link
Member

alloy commented Apr 18, 2014

👍

Ashton-W pushed a commit to Ashton-W/Core that referenced this pull request Nov 2, 2015
…mmits_in_yaml_squashed

Show informative error message when a merge conflict is detected in a YAML file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants